docs: Fixed component exports for tanstack/start #979
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
Warning Rate limit exceeded@juraj98 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 0 minutes and 29 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe changes involve modifying the export statements for the Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
juliusmarminge
left a comment
juliusmarminge
left a comment
There was a problem hiding this comment.
The import in the index route uses default import so it wasn't wrong?
Definitely prefer named ones though so just update the import as well!
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- docs/src/app/(docs)/getting-started/tanstack-start/page.mdx (1 hunks)
Additional comments not posted (1)
docs/src/app/(docs)/getting-started/tanstack-start/page.mdx (1)
125-126: LGTM! Export changes look good.The changes to named exports for
UploadButtonandUploadDropzoneare correct and align with the PR objectives. This improves consistency and clarity for importing these components.To ensure these changes don't break existing documentation or code, please run the following script to check for any imports that may need updating:
If the script returns any results, those files may need to be updated to use the new named export syntax.
Verification successful
All import statements for
UploadButtonandUploadDropzoneare correctly using named exports. No further changes are necessary.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for imports of UploadButton and UploadDropzone that may need updating # Search for imports of UploadButton echo "Checking UploadButton imports:" rg --type mdx --type tsx 'import.*UploadButton.*from.*utils/uploadthing' # Search for imports of UploadDropzone echo "Checking UploadDropzone imports:" rg --type mdx --type tsx 'import.*UploadDropzone.*from.*utils/uploadthing'Length of output: 353
Script:
#!/bin/bash # Description: Check for imports of UploadButton and UploadDropzone that may need updating # Search for imports of UploadButton echo "Checking UploadButton imports in .mdx and .tsx files:" rg --glob '*.mdx' --glob '*.tsx' 'import.*UploadButton.*from.*utils/uploadthing' # Search for imports of UploadDropzone echo "Checking UploadDropzone imports in .mdx and .tsx files:" rg --glob '*.mdx' --glob '*.tsx' 'import.*UploadDropzone.*from.*utils/uploadthing'Length of output: 1967
Done |
2 participants
Follow up for #973.
Exports for
UploadButtonandUploadDropzonewere incorrect in getting started for@tanstack/start. Noticed it only after the original PR was merged.Summary by CodeRabbit
UploadButtonandUploadDropzonecomponents through named exports, allowing for more flexible imports in other modules.