feat: Add `onChange` + various feature parity additions/fixes #886

markflorkowski · 2024-07-12T17:53:13Z

Unifies the API between components
Marks onDrop as deprecated.

Additional changes:

Fixes disabled styling (Discord)
Adds/fixes paste functionality on all current FE packages
Adds/fixes upload abort functionality on all current packages
Tested functionality is equivalent across all current FE packages

changeset-bot · 2024-07-12T17:53:16Z

🦋 Changeset detected

Latest commit: cf6337f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages

Name	Type
@uploadthing/react	Minor
@uploadthing/solid	Minor
@uploadthing/svelte	Minor
@uploadthing/vue	Minor
@uploadthing/expo	Patch
@uploadthing/nuxt	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2024-07-12T17:53:16Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-uploadthing	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 5, 2024 10:52pm

github-actions · 2024-07-12T17:54:48Z

📦 Bundle size comparison

Bundle	Size (gzip)	Visualization
Main	39.85KB	See Treemap 📊
PR (`25f1a30`)	39.85KB	See Treemap 📊
Diff	No change

pkg-pr-new · 2024-07-12T21:42:26Z

Open in Stackblitz

More templates

@uploadthing/dropzone

pnpm add https://pkg.pr.new/pingdotgg/uploadthing/@uploadthing/dropzone@886

@uploadthing/nuxt

pnpm add https://pkg.pr.new/pingdotgg/uploadthing/@uploadthing/nuxt@886

@uploadthing/react

pnpm add https://pkg.pr.new/pingdotgg/uploadthing/@uploadthing/react@886

@uploadthing/solid

pnpm add https://pkg.pr.new/pingdotgg/uploadthing/@uploadthing/solid@886

@uploadthing/svelte

pnpm add https://pkg.pr.new/pingdotgg/uploadthing/@uploadthing/svelte@886

uploadthing

pnpm add https://pkg.pr.new/pingdotgg/uploadthing@886

@uploadthing/vue

pnpm add https://pkg.pr.new/pingdotgg/uploadthing/@uploadthing/vue@886

commit: cf6337f

docs/src/pages/api-reference/react.mdx

github-actions · 2024-08-06T17:11:54Z

A new canary is available for testing. You can install this latest build in your project with:

pnpm add @uploadthing/[email protected]
pnpm add @uploadthing/[email protected]
pnpm add @uploadthing/[email protected]
pnpm add @uploadthing/[email protected]
pnpm add @uploadthing/[email protected]
pnpm add @uploadthing/[email protected]
pnpm add @uploadthing/[email protected]
pnpm add @uploadthing/[email protected]
pnpm add [email protected]
pnpm add @uploadthing/[email protected]

.github/workflows/pkg-pr-new.yaml

juliusmarminge · 2024-09-03T21:18:48Z

docs/src/pages/api-reference/react.mdx

reminder for myself: copy these changes to new docs

packages/dropzone/src/svelte.ts

packages/react/src/components/button.tsx

Co-authored-by: Mark R. Florkowski <[email protected]>

t3dotgg

lgtm, ty for the lift here

add onSelect to <UploadButton/>

d7c6034

github-actions bot added 📚 documentation @uploadthing/react labels Jul 12, 2024

vercel bot deployed to Preview July 12, 2024 17:55 View deployment

exhaustive deps

5e5466d

vercel bot deployed to Preview July 12, 2024 18:49 View deployment

markflorkowski added 3 commits July 12, 2024 12:31

solid

f011e33

svelte

52b616c

vue

3f050ec

markflorkowski requested a review from juliusmarminge July 12, 2024 19:36

markflorkowski added 2 commits July 12, 2024 12:38

optional on svelte

27bec4d

rm unused import

ad23bdb

juliusmarminge approved these changes Jul 12, 2024

View reviewed changes

Create giant-candles-wash.md

89e53bb

vercel bot deployed to Preview July 12, 2024 21:27 View deployment

fix pkg-pr-new action?

6e38c3b

vercel bot deployed to Preview July 12, 2024 21:34 View deployment

try again

4e3e915

vercel bot deployed to Preview July 12, 2024 21:39 View deployment

fetch depth

4c05d8f

vercel bot deployed to Preview July 12, 2024 21:41 View deployment

juliusmarminge reviewed Jul 12, 2024

View reviewed changes

docs/src/pages/api-reference/react.mdx Outdated Show resolved Hide resolved

docs callout about files []

5f857b2

vercel bot deployed to Preview July 12, 2024 21:58 View deployment

markflorkowski changed the title ~~feat: Add onSelect to <UploadButton/>~~ feat: Add onChange to <UploadButton/> and <UploadDropzone/> Jul 13, 2024

onDrop -> onChange

d49ea8f

vercel bot deployed to Preview August 2, 2024 20:30 View deployment

markflorkowski mentioned this pull request Aug 5, 2024

[bug]: Cannot read properties of undefined (reading 'ordinal') #900

Closed

2 tasks

markflorkowski added the release canary Trigger a canary release to npm label Aug 6, 2024

github-actions bot removed the release canary Trigger a canary release to npm label Aug 6, 2024

markflorkowski added 2 commits August 7, 2024 13:21

use .value on upload progress

7d716b2

also on dropzone

5546dfc

markflorkowski mentioned this pull request Aug 26, 2024

[bug]:UploadDropZone component in Svelte prompts for multiple files even if endpoint has only one file allowed (then silently fails) #923

Closed

2 tasks

markflorkowski changed the title ~~feat: Add onChange to <UploadButton/> and <UploadDropzone/>~~ feat: Add onChange + various feature parity additions/fixes Aug 26, 2024

Merge branch 'main' into mark/on-button-select

0da1aeb

vercel bot deployed to Preview September 3, 2024 20:55 View deployment

juliusmarminge reviewed Sep 3, 2024

View reviewed changes

.github/workflows/pkg-pr-new.yaml Outdated Show resolved Hide resolved

juliusmarminge reviewed Sep 3, 2024

View reviewed changes

docs/src/pages/api-reference/react.mdx

Copy link

Member

juliusmarminge Sep 3, 2024 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reminder for myself: copy these changes to new docs

juliusmarminge reviewed Sep 3, 2024

View reviewed changes

review feedback

02a78dd

vercel bot deployed to Preview September 3, 2024 22:02 View deployment

update action to use

885f3e0

vercel bot deployed to Preview September 3, 2024 22:06 View deployment

remove await

ee8550c

vercel bot deployed to Preview September 3, 2024 22:10 View deployment

juliusmarminge mentioned this pull request Sep 4, 2024

feat: customisable composable components #910

Open

1 task

refactor renderButton

7478a92

vercel bot deployed to Preview September 4, 2024 23:35 View deployment

chore: init some component tests (#898)

cf6337f

Co-authored-by: Mark R. Florkowski <[email protected]>

vercel bot deployed to Preview September 5, 2024 22:52 View deployment

t3dotgg approved these changes Sep 6, 2024

View reviewed changes

markflorkowski merged commit 079b434 into main Sep 6, 2024

This was referenced Sep 19, 2024

[bug]: Multiple file uploads seem to trigger twice #965

Closed

fix: dropzone behavior #980

Merged

coderabbitai bot mentioned this pull request Jan 4, 2025

chore(release): 📦 version packages #1115

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Add `onChange` + various feature parity additions/fixes #886

feat: Add `onChange` + various feature parity additions/fixes #886

Uh oh!

markflorkowski commented Jul 12, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Jul 12, 2024 •

edited

Loading

Uh oh!

vercel bot commented Jul 12, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Jul 12, 2024 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Jul 12, 2024 •

edited

Loading

Uh oh!

Uh oh!

github-actions bot commented Aug 6, 2024

Uh oh!

Uh oh!

juliusmarminge Sep 3, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

t3dotgg left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat: Add onChange + various feature parity additions/fixes #886

feat: Add onChange + various feature parity additions/fixes #886

Uh oh!

Conversation

markflorkowski commented Jul 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Jul 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

vercel bot commented Jul 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Bundle size comparison

Uh oh!

pkg-pr-new bot commented Jul 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Aug 6, 2024

Uh oh!

Uh oh!

juliusmarminge Sep 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

t3dotgg left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat: Add `onChange` + various feature parity additions/fixes #886

feat: Add `onChange` + various feature parity additions/fixes #886

markflorkowski commented Jul 12, 2024 •

edited

Loading

changeset-bot bot commented Jul 12, 2024 •

edited

Loading

vercel bot commented Jul 12, 2024 •

edited

Loading

github-actions bot commented Jul 12, 2024 •

edited

Loading

pkg-pr-new bot commented Jul 12, 2024 •

edited

Loading

juliusmarminge Sep 3, 2024 •

edited

Loading