chore: Bump svelte peer dependency #1006

AlanAcDz · 2024-10-11T01:34:59Z

Bump svelte peer dependency to include svelte 5 RC, closes #967

I would have liked to also bump the svelte version on the sveltekit example to make it easier to test, but it would break the build of the svelte package afterwards.

Summary by CodeRabbit

New Features
- Updated dependencies for improved performance and compatibility.
- Enhanced support for Svelte 5 alongside Svelte 4 in the package configuration.
Bug Fixes
- Incremented versions of key dependencies to ensure stability and access to the latest features.

changeset-bot · 2024-10-11T01:35:03Z

⚠️ No Changeset found

Latest commit: 0121967

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2024-10-11T01:35:06Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-uploadthing	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 14, 2024 7:48am

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
legacy-docs-uploadthing	⬜️ Ignored (Inspect)	Visit Preview		Oct 14, 2024 7:48am

coderabbitai · 2024-10-11T01:35:08Z

Walkthrough

The pull request updates the package.json files for both the @example/minimal-sveltekit project and the @uploadthing/svelte package. Specifically, it increments the version of @uploadthing/svelte and svelte from 7.0.3 to 7.0.4. Additionally, it modifies the peerDependencies in the @uploadthing/svelte package to support both Svelte 4 and the next version of Svelte 5.

Changes

File Path	Change Summary
examples/minimal-sveltekit/package.json	Updated dependency `@uploadthing/svelte` from `7.0.3` to `7.0.4`.
packages/svelte/package.json	Updated version from `7.0.3` to `7.0.4` and modified `peerDependencies` for `svelte` to `"^4.0.0

Assessment against linked issues

Objective	Addressed	Explanation
Support for Svelte 5 in @uploadthing/svelte (967)	✅

Possibly related PRs

chore: update effect/platform past API changes #1005: This PR updates the packages/svelte/package.json file to change the version of the vite dependency, which is also reflected in the main PR's updates to the same file.

🐇 In the garden, I hop with glee,
Versions updated, oh what a spree!
Svelte and Uploadthing, hand in hand,
Compatibility now, isn't it grand?
With each little change, we grow and thrive,
In the world of code, we come alive! 🌱

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 1f2a6a8 and 0121967.

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (2)

examples/minimal-sveltekit/package.json (1 hunks)
packages/svelte/package.json (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

examples/minimal-sveltekit/package.json
packages/svelte/package.json

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

juliusmarminge · 2024-10-11T05:52:05Z

packages/svelte/package.json

  ],
  "peerDependencies": {
-    "svelte": "^4.0.0",
+    "svelte": "^4.0.0 || ^5.0.0-next.0",


When is this expected to land as stable? I don't know many libs that include prereleases in their peer dep range (e.g React 19 and Next 15 you just have to deal with 100 packages yelling).

Also since none of us are familiar with Svelte we don't wanna bump this and have an expectation to fix it if they introduce some breaking change before official release

I cannot say when will it land as stable, but it has been in RC state for a while now so I would soon-ish. v5 should be fully compatible with v4 so even if a breaking change is introduced it would only affect v5 specific features not the v4 ones.

Also, the sveltekit package includes the very same peer dependency for svelte as this PR introduces, so I would say it's pretty safe. For reference: https://github.com/sveltejs/kit/blob/main/packages/kit/package.json

Ok 👍 I'll let @markflorkowski have the final say

juliusmarminge · 2024-10-14T07:47:04Z

I would have liked to also bump the svelte version on the sveltekit example to make it easier to test, but it would break the build of the svelte package afterwards.

Can you elaborate on this @AlanAcDz ? Is it something that can be done once stable is out or what's blocking it?

juliusmarminge

Would like either @markflorkowski or @t3dotgg to approve bumping peer dep to a preview release

juliusmarminge · 2024-10-14T15:46:08Z

Mark approved

This reverts commit adb002c.

AlanAcDz · 2024-10-15T04:58:25Z

I would have liked to also bump the svelte version on the sveltekit example to make it easier to test, but it would break the build of the svelte package afterwards.

Can you elaborate on this @AlanAcDz ? Is it something that can be done once stable is out or what's blocking it?

Yeah, both the sveltekit example and the svelte package use svelte v4 atm, if you bump only the example version it breaks the build of the package because of how the monorepo manages dependencies.

chore: Bump svelte peer dependency

1f2a6a8

vercel bot deployed to Preview – docs-uploadthing October 11, 2024 01:40 View deployment

juliusmarminge reviewed Oct 11, 2024

View reviewed changes

Merge branch 'main' into bump-svelte

0121967

juliusmarminge approved these changes Oct 14, 2024

View reviewed changes

vercel bot deployed to Preview – docs-uploadthing October 14, 2024 07:48 View deployment

juliusmarminge merged commit adb002c into pingdotgg:main Oct 14, 2024

juliusmarminge added a commit that referenced this pull request Oct 14, 2024

Revert "chore: Bump svelte peer dependency (#1006)"

40c9407

This reverts commit adb002c.

juliusmarminge mentioned this pull request Oct 14, 2024

Revert "chore: Bump svelte peer dependency" #1011

Closed

t3dotgg mentioned this pull request Oct 14, 2024

chore(release): 📦 version packages #1010

Merged

This was referenced Nov 12, 2024

feat: Migrate Svelte package to Svelte 5 #1049

Open

chore(release): 📦 version packages #1059

Merged

coderabbitai bot mentioned this pull request Dec 12, 2024

chore(release): 📦 version packages #1096

Merged

This was referenced Dec 30, 2024

chore: bump react peer dep and bunchee #1102

Closed

chore(release): 📦 version packages #1109

Merged

chore(release): 📦 version packages #1115

Merged

chore: Bump svelte peer dependency #1006

chore: Bump svelte peer dependency #1006

Uh oh!

Conversation

AlanAcDz commented Oct 11, 2024 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented Oct 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

vercel bot commented Oct 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Oct 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

juliusmarminge Oct 11, 2024

Choose a reason for hiding this comment

Uh oh!

AlanAcDz Oct 11, 2024

Choose a reason for hiding this comment

Uh oh!

juliusmarminge Oct 11, 2024

Choose a reason for hiding this comment

Uh oh!

juliusmarminge commented Oct 14, 2024

Uh oh!

juliusmarminge left a comment

Choose a reason for hiding this comment

Uh oh!

juliusmarminge commented Oct 14, 2024

Uh oh!

AlanAcDz commented Oct 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

AlanAcDz commented Oct 11, 2024 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Oct 11, 2024 •

edited

Loading

vercel bot commented Oct 11, 2024 •

edited

Loading

coderabbitai bot commented Oct 11, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)