This repository was archived by the owner on Sep 9, 2024. It is now read-only.
fix: only merge non-enumerable global properties that are not in VM scope #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorber
approved these changes
Mar 24, 2022
| for (var k, i = 0, n = keys.length; i < n; i++) { | ||
| k = keys[i] | ||
| a[k] = b[k] | ||
| } | ||
| return a | ||
| } | ||
|
|
||
| var vmGlobals = new vm.Script('vmGlobals = Object.getOwnPropertyNames(globalThis)') |
There was a problem hiding this comment.
Review hint:
-
👍 eager call but only takes < 1ms for my mac
-
List is:
[
"Object",
"Function",
"Array",
"Number",
"parseFloat",
"parseInt",
"Infinity",
"NaN",
"undefined",
"Boolean",
"String",
"Symbol",
"Date",
"Promise",
"RegExp",
"Error",
"AggregateError",
"EvalError",
"RangeError",
"ReferenceError",
"SyntaxError",
"TypeError",
"URIError",
"globalThis",
"JSON",
"Math",
"console",
"Intl",
"ArrayBuffer",
"Uint8Array",
"Int8Array",
"Uint16Array",
"Int16Array",
"Uint32Array",
"Int32Array",
"Float32Array",
"Float64Array",
"Uint8ClampedArray",
"BigUint64Array",
"BigInt64Array",
"DataView",
"Map",
"BigInt",
"Set",
"WeakMap",
"WeakSet",
"Proxy",
"Reflect",
"FinalizationRegistry",
"WeakRef",
"decodeURI",
"decodeURIComponent",
"encodeURI",
"encodeURIComponent",
"escape",
"unescape",
"eval",
"isFinite",
"isNaN",
"SharedArrayBuffer",
"Atomics",
"WebAssembly",
];| if (!vmGlobals.includes(name)) { | ||
| sandbox[name] = global[name] | ||
| } | ||
| }) |
There was a problem hiding this comment.
Review hint
New globals automatically forwarded:
[
"global",
"process",
"Buffer",
"atob",
"btoa",
"URL",
"URLSearchParams",
"TextEncoder",
"TextDecoder",
"AbortController",
"AbortSignal",
"EventTarget",
"Event",
"MessageChannel",
"MessagePort",
"MessageEvent",
"clearInterval",
"clearTimeout",
"setInterval",
"setTimeout",
"queueMicrotask",
"performance",
"clearImmediate",
"setImmediate",
"__extends",
"__assign",
"__rest",
"__decorate",
"__param",
"__metadata",
"__awaiter",
"__generator",
"__exportStar",
"__createBinding",
"__values",
"__read",
"__spread",
"__spreadArrays",
"__spreadArray",
"__await",
"__asyncGenerator",
"__asyncDelegator",
"__asyncValues",
"__makeTemplateObject",
"__importStar",
"__importDefault",
"__classPrivateFieldGet",
"__classPrivateFieldSet",
"consola",
"regeneratorRuntime",
];There was a problem hiding this comment.
Most of these globals are injected by the transpiler. Only stuff like URL process TextDecoder etc. are of our interest.
I don't think that's necessarily the goal of this module and I frankly can't see how that's useful after this bug is fixed😅 Since we have a forked SSG plugin, if you really want to exclude some globals, just use |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #27. Fix #29
Case as where #27 failed:
Because the
globalThisin this case is an exotic object, the latterPrismisn't actually made a "global".Logs
falsebecauseObjectis exotic. RemovingObjectfrom the scope causes it to logtrue.The resolution is to filter out anything that's already in the VM scope.
cc @pierrec This is a hotfix.
cc @slorber FYI