[BUGFIX] Ensure temp directory exists before calling tempnam() #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CybotTM
force-pushed
the
bugfix/plantuml-tempnam-notice
branch
from
cb0cbc1 to
5c1abfd
Compare
The tempnam() call uses a subdirectory of sys_get_temp_dir() that may not exist, which triggers a PHP E_NOTICE when the directory is missing. PHP then falls back to the system temp directory, but the notice can appear in rendered output. This creates the directory if it doesn't exist before calling tempnam(), preventing the notice. Fixes: phpDocumentor#1
Adds a unit test to verify that the temp directory is created before calling tempnam(), preventing the E_NOTICE regression.
Extracts the temp subdirectory path to a public constant so tests can reference it directly, ensuring they stay in sync with the implementation.
CybotTM
force-pushed
the
bugfix/plantuml-tempnam-notice
branch
from
5c1abfd to
73b3b4e
Compare
4 tasks
Member
|
Thanks for your contribution, unfortunately I cannot merge this into this repository. As described in our contribution file pr's should be done on phpDocumentor/guides repository. This repository is a read-only split from this main repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1
The
tempnam()call inPlantumlRenderer::render()uses a subdirectory ofsys_get_temp_dir()that may not exist, which triggers a PHPE_NOTICE:This notice can appear in rendered documentation output when error reporting includes
E_NOTICE.Changes
/phpdocumentorsubdirectory if it doesn't exist before callingtempnam()Test plan
renderer="plantuml")/tmp/phpdocumentordoes not exist.. uml::directiveE_NOTICEis emitted