Skip to content

Attempt to fix bug #79092 (Building with clang+lld-9 results in a broken PHP binary) #5123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Attempt to fix bug #79092 (Building with clang+lld-9 results in a broken PHP binary) #5123

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
afda14a
Attempt to fix bug #79092 (Building with clang+lld-9 results in a bro…
dstogov Jan 28, 2020
f002a05
Removed '$'
dstogov Jan 29, 2020
bd58c27
Move "page-size" checks into a better place (before reseting LDFLAGS)
dstogov Jan 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 36 additions & 7 deletions configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1050,6 +1050,42 @@ esyscmd(./build/config-stubs ext)
dnl Extensions post-config.
dnl ----------------------------------------------------------------------------

dnl Align segments on huge page boundary
case $host_alias in
i[[3456]]86-*-linux-* | x86_64-*-linux-*)
AC_MSG_CHECKING(linker support for -zcommon-page-size=2097152)
save_LDFLAGS=$LDFLAGS
LDFLAGS="$LDFLAGS -Wl,-zcommon-page-size=2097152 -Wl,-zmax-page-size=2097152"
AC_RUN_IFELSE(
[AC_LANG_SOURCE([[int main() {return 0;}]])],
[ac_cv_common_page_size=yes],
[ac_cv_common_page_size=no],
[ac_cv_common_page_size=no])
LDFLAGS=$save_LDFLAGS
if test "$ac_cv_common_page_size" = "yes"; then
AC_MSG_RESULT([yes])
EXTRA_LDFLAGS_PROGRAM="$EXTRA_LDFLAGS_PROGRAM -Wl,-zcommon-page-size=2097152 -Wl,-zmax-page-size=2097152"
else
AC_MSG_RESULT([no])
AC_MSG_CHECKING(linker support for -zmax-page-size=2097152)
save_LDFLAGS=$LDFLAGS
LDFLAGS="$LDFLAGS -Wl,-zmax-page-size=2097152"
AC_RUN_IFELSE(
[AC_LANG_SOURCE([[int main() {return 0;}]])],
[ac_cv_max_page_size=yes],
[ac_cv_max_page_size=no],
[ac_cv_max_page_size=no])
LDFLAGS=$save_LDFLAGS
if test "$ac_cv_max_page_size" = "yes"; then
AC_MSG_RESULT([yes])
EXTRA_LDFLAGS_PROGRAM="$EXTRA_LDFLAGS_PROGRAM -Wl,-zmax-page-size=2097152"
else
AC_MSG_RESULT([no])
fi
fi
;;
esac

enable_shared=yes
enable_static=yes

Expand Down Expand Up @@ -1168,13 +1204,6 @@ if test "$PHP_THREAD_SAFETY" = "yes"; then
TSRM_THREADS_CHECKS
fi

dnl Align segments on huge page boundary
case $host_alias in
i[[3456]]86-*-linux-* | x86_64-*-linux-*)
EXTRA_LDFLAGS_PROGRAM="$EXTRA_LDFLAGS_PROGRAM -Wl,-zcommon-page-size=2097152 -Wl,-zmax-page-size=2097152"
;;
esac

EXTRA_LDFLAGS="$EXTRA_LDFLAGS $LDFLAGS"
EXTRA_LDFLAGS_PROGRAM="$EXTRA_LDFLAGS_PROGRAM $LDFLAGS"
EXTRA_LIBS="$EXTRA_LIBS $LIBS"
Expand Down