Deprecate returning non-string values from a user output handler #18932
+360
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimWolla
reviewed
Jun 24, 2025
main/output.c
Outdated
| "Returning a non-string result from user output handler %s is deprecated", | ||
| ZSTR_VAL(handler->name) | ||
| ); | ||
| OG(flags) = old_flags; |
There was a problem hiding this comment.
Do you also need to check EG(exception) for a throwing error handler?
There was a problem hiding this comment.
Probably, this is just so I can run the full CI and find failures at the moment, the disabling of output buffers is wrong (segfault) and I'm fixing it now
There was a problem hiding this comment.
Actually looks like we don't actually need to check EG(exception) because I switched to only disabling the specific handler that was problematic
And update tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wiki.php.net/rfc/deprecations_php_8_4