Skip to content

Implemented ReflectionFunction::isGenerator() #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2012
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ext/reflection/php_reflection.c
Original file line number Diff line number Diff line change
Expand Up @@ -3086,6 +3086,14 @@ ZEND_METHOD(reflection_function, isDeprecated)
}
/* }}} */

/* {{{ proto public bool ReflectionFunction::isGenerator()
Returns whether this function is a generator */
ZEND_METHOD(reflection_function, isGenerator)
{
_function_check_flag(INTERNAL_FUNCTION_PARAM_PASSTHRU, ZEND_ACC_GENERATOR);
}
/* }}} */

/* {{{ proto public bool ReflectionFunction::inNamespace()
Returns whether this function is defined in namespace */
ZEND_METHOD(reflection_function, inNamespace)
Expand Down Expand Up @@ -5696,6 +5704,7 @@ static const zend_function_entry reflection_function_abstract_functions[] = {
ZEND_ME(reflection_function, isDeprecated, arginfo_reflection__void, 0)
ZEND_ME(reflection_function, isInternal, arginfo_reflection__void, 0)
ZEND_ME(reflection_function, isUserDefined, arginfo_reflection__void, 0)
ZEND_ME(reflection_function, isGenerator, arginfo_reflection__void, 0)
ZEND_ME(reflection_function, getClosureThis, arginfo_reflection__void, 0)
ZEND_ME(reflection_function, getClosureScopeClass, arginfo_reflection__void, 0)
ZEND_ME(reflection_function, getDocComment, arginfo_reflection__void, 0)
Expand Down
52 changes: 52 additions & 0 deletions ext/reflection/tests/ReflectionFunction_isGenerator_basic.phpt
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
--TEST--
ReflectionFunction::isGenerator()
--FILE--
<?php

$closure1 = function() {return "this is a closure"; };
$closure2 = function($param) {
yield $param;
};

$rf1 = new ReflectionFunction($closure1);
var_dump($rf1->isGenerator());

$rf2 = new ReflectionFunction($closure2);
var_dump($rf2->isGenerator());

function func1() {
return 'func1';
}

function func2() {
yield 'func2';
}

$rf1 = new ReflectionFunction('func1');
var_dump($rf1->isGenerator());

$rf2 = new ReflectionFunction('func2');
var_dump($rf2->isGenerator());


class Foo {
public function f1() {
}

public function f2() {
yield;
}
}

$rc = new ReflectionClass('Foo');
foreach($rc->getMethods() as $m) {
var_dump($m->isGenerator());
}
?>
--EXPECTF--
bool(false)
bool(true)
bool(false)
bool(true)
bool(false)
bool(true)