Autotools: Remove too basic optimization flag cleanup #15305
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The optimization flags are removed in configure.ac when using --enable-debug. When using --enable-debug-assertions the optimization flags shouldn't ideally be removed and this case never actually happen because the CFLAGS at this point in ZEND_INIT contain all sorts of other flags also, so it's redundant as it never gets executed.
Girgias
approved these changes
Aug 9, 2024
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
Makes sense, especially as the --enable-debug option actually sets -O0 too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The optimization flags are removed in configure.ac when using --enable-debug. When using --enable-debug-assertions the optimization flags shouldn't ideally be removed and this case never actually happen because the CFLAGS at this point in ZEND_INIT contain all sorts of other flags also, so it's redundant as it never gets executed.