Skip to content

ext/pdo: Fixed parent class of subclass stubs #14990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SakiTakamachi merged 1 commit into from
Jul 17, 2024
Merged

ext/pdo: Fixed parent class of subclass stubs #14990

SakiTakamachi merged 1 commit into from
Jul 17, 2024

Conversation

@SakiTakamachi
Copy link
Member

@SakiTakamachi SakiTakamachi commented Jul 17, 2024

The parent class was Pdo\PDO, so I changed it to \PDO.

Girgias
Girgias approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible

devnexen
devnexen approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lctm

@SakiTakamachi SakiTakamachi merged commit acd6ac3 into php:master Jul 17, 2024
@SakiTakamachi SakiTakamachi deleted the fix/pdo_subclasses branch July 17, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devnexen devnexen devnexen approved these changes

@Girgias Girgias Girgias approved these changes

@kocsismate kocsismate Awaiting requested review from kocsismate kocsismate is a code owner

@NattyNarwhal NattyNarwhal Awaiting requested review from NattyNarwhal NattyNarwhal is a code owner

Assignees

No one assigned

Labels

Extension: pdo_dblib Extension: pdo_firebird Extension: pdo_mysql Extension: pdo_odbc Extension: pdo_pgsql Extension: pdo_sqlite

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SakiTakamachi @devnexen @Girgias