Missing function documentation for pcntl_wifcontinued and pcntl_forkx #4918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
reviewed
Dec 14, 2025
| <refentry xml:id="function.pcntl-forkx" xmlns="http://docbook.org/ns/docbook"> | ||
| <refnamediv> | ||
| <refname>pcntl_forkx</refname> | ||
| <refpurpose>Forks the currently running process, with additional options (Solaris only)</refpurpose> |
Member
There was a problem hiding this comment.
nit: Solaris only, illumos systems support it too
devnexen
reviewed
Dec 14, 2025
| <methodparam><type>int</type><parameter>flags</parameter></methodparam> | ||
| </methodsynopsis> | ||
| <para> | ||
| The <function>pcntl_forkx</function> function creates a child |
Member
There was a problem hiding this comment.
note that forkx, x stands for extended version of. Also what is mentioned here is true, unless you pass flags so even though there is 'read the manual if you want to know more', a little mention of these would not kill :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2163
As I don't have a Solaris box, the pcntl_forkx documentation is based on the php-src code and comments, combined with the Solaris documentation
pcntl_wifcontinued is wrapped in an ifdef in php-src. Based on commit / NEWS history this was because it wasn't available on NetBSD (but based on search results appears to be in more recent versions). Is this significant enough to note? eg. A note along the lines of: