PHP 8.4: Document SplObjectStorage::seek() #4048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pushed commits, including 2 drive-by fixes:
|
Girgias
commented
Nov 12, 2024
Comment on lines
21
to
33
| &reftitle.parameters; | ||
| <simpara> | ||
| <para> | ||
| <variablelist> | ||
| <varlistentry> | ||
| <term><parameter>offset</parameter></term> | ||
| <listitem> | ||
| <simpara> | ||
| Description. | ||
| The position to seek to. | ||
| </simpara> | ||
| </listitem> | ||
| </varlistentry> | ||
| </variablelist> | ||
| </simpara> | ||
| </para> |
There was a problem hiding this comment.
Ideally this wrapping para should be removed, but I'm fine to leave the <para> tag if it is pre-exiting
There was a problem hiding this comment.
The simpara came out of the stub generator, but that was wrong so I changed it back to para: php/php-src#16764
Girgias
commented
Nov 12, 2024
|
I think this could be merged, no? |
siwa32
added a commit
to siwa32/doc-ja
that referenced
this pull request
Dec 19, 2024
KentarouTakeda
pushed a commit
to php/doc-ja
that referenced
this pull request
Dec 21, 2024
* インデントの修正 * PHP 8.4: Document SplObjectStorage::seek()を翻訳 php/doc-en#4048
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nielsdos could you document this as, IIRC, you added this?
Related (#4047)