SettingsParseArgumentsTest: improve the tests #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the tests in the `SettingsParseArgumentsTest` class to use a data provider, which allow for adding more tests in a straight forward manner. Includes expanding the actual tested settings values (values of the properties in the `Settings` class). Previously, there were two tests which tested a range of property values, though still not all and multiple other tests which only verified one particular property value. With the adjusted setup, all property values, except for the `phpExecutable`, will be tested for each and every test case. Note: this is a 1-on-1 refactor of the test with all existing test cases still being tested but no other changes.
... to make sure all possible arguments handled by the `Settings::parseArguments()` method are covered by tests.
grogy
approved these changes
Mar 21, 2022
Member
|
Thank you, additionals tests after rewrite data provider is so better :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SettingsParseArgumentsTest: refactor to dataprovider
Refactor the tests in the
SettingsParseArgumentsTestclass to use a data provider, which allow for adding more tests in a straight forward manner.Includes expanding the actual tested settings values (values of the properties in the
Settingsclass).Previously, there were two tests which tested a range of property values, though still not all and multiple other tests which only verified one particular property value.
With the adjusted setup, all property values, except for the
phpExecutable, will be tested for each and every test case.Note: this is a 1-on-1 refactor of the test with all existing test cases still being tested but no other changes.
SettingsParseArgumentsTest: add additional test cases
... to make sure all possible arguments handled by the
Settings::parseArguments()method are covered by tests.SettingsParseArgumentsTest: add new test for handling of unsupported arguments
SettingsParseArgumentsTest: add
@coverstags