Skip to content

Separate interfaces for client, server and networking exceptions #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ddeboer opened this issue May 25, 2015 · 3 comments
Closed

Separate interfaces for client, server and networking exceptions #26

ddeboer opened this issue May 25, 2015 · 3 comments

Comments

@ddeboer
Copy link
Contributor

ddeboer commented May 25, 2015

As discussed in #10.

@sagikazarmark
Copy link
Member

I have to mention that it is not that easy to differentiate between errors, since each HTTP Clients handle errors differently: some throws exceptions for 4xx status code responses, some don't. Currently we return every response if any, even if 4xx or 5xx responses.

@ddeboer
Copy link
Contributor Author

ddeboer commented May 25, 2015

That’s an option too, at least for requests that return a response. I think you need to throw an exception at least for cases where a networking timeout occurs.

@sagikazarmark
Copy link
Member

That's true, AFAIK we do it ATM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants