Skip to content

Create common Exception interface, break exceptions into smaller parts #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sagikazarmark opened this issue May 15, 2015 · 2 comments
Closed

Create common Exception interface, break exceptions into smaller parts #10

sagikazarmark opened this issue May 15, 2015 · 2 comments

Comments

@sagikazarmark
Copy link
Member

It is a common practice to introduce a generic Exception interface so that all exceptions thrown by this library can be caught in a single catch.

Also, as discussed on gitter, we should create more exceptions instead of one or two big ones.
@sagikazarmark sagikazarmark mentioned this issue May 16, 2015
Closed
@ddeboer
Copy link
Contributor

ddeboer commented May 25, 2015

👍

At least differentiate between client exceptions (400s), server exceptions (500s) and networking errors (timeouts and such).

@sagikazarmark
Copy link
Member Author

That's a good point.

Currently the separation is based on single and multi requests.

Can you open a separate issue for that?

@ddeboer ddeboer mentioned this issue May 25, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ddeboer @sagikazarmark