add documentation for retry and redirect plugins, split building own, document library usage #87
Conversation
| @@ -1,5 +1,3 @@ | |||
| .. _client-common: | |||
There was a problem hiding this comment.
i propose we stop using labels for whole doc chapters
There was a problem hiding this comment.
Don't really know why or why not, so fine with me :)
There was a problem hiding this comment.
I guess he means using doc reference instead. Am I right?
There was a problem hiding this comment.
with a label like this, you write :ref:client-common. but to specify a whole chapter, you can do:doc:`/path/to/client-common```. i would only use labels when we want to deep link to specific sections.
dbu
force-pushed
the
plugins-redirect-retry-library-custom
branch
2 times, most recently
from
4c3439b to
14d316f
Compare
clients/curl-client.rst
Outdated
| ----- | ||
|
|
||
| The cURL client needs a :ref:`message <message-factory>` and a :ref:`stream <message-factory>` | ||
| The cURL client needs a :ref:`message <message-factory>` and a :ref:`stream <stream-factory>` |
There was a problem hiding this comment.
This could be mentioned in the installation instructions as well. See guzzle5 doc.
|
👍 |
dbu
force-pushed
the
plugins-redirect-retry-library-custom
branch
from
2bdf91c to
2778145
Compare
| .. include:: includes/install-message-factory.inc | ||
|
|
||
| use Http\Client\Curl\Client; | ||
| .. include:: includes/install-discovery.inc |
There was a problem hiding this comment.
@sagikazarmark is this what you meant by mentioning the factories in the installation instructions?
There was a problem hiding this comment.
+The cURL client needs a :ref:
message factory <message-factory>and
I meant this. If the message factory is necessary, it probably worths mentioning in the install instructions:
http://docs.php-http.org/en/latest/clients/guzzle5-adapter.html#installation
There are two include files for that.
There was a problem hiding this comment.
which i now include. correct like this?
There was a problem hiding this comment.
Yeah, missed that they are included.
|
LGTM IMO, go merge ? |
|
Those two sentences are not major ones I think. So from my point of view go ahead. |
…ustom add documentation for retry and redirect plugins, split building own, document library usage
fix #33, #35, #75
sorry, i started to mix up several things in one PR here. i hope we can solve the questions and merge things together - tried committing in parts but
git add -pdid not split into small enough bits.