Skip to content
This repository was archived by the owner on Mar 30, 2022. It is now read-only.

Fix the lib for v0.5 and v0.6 of nodejs. It's also backward compatible with v0.4 #19

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

alaingilbert
Copy link

Fix the lib for v0.5 and v0.6 of nodejs. It's also backward compatible with v0.4

@quangv
Copy link

quangv commented Nov 18, 2011

hey alain,

thanks for the fix. I merged it with mine, and added try/catches,

would your fix still work if it's done that way?

checkout https://github.com/pgriess/node-websocket-client/pull/21/files

Thanks.

@alaingilbert
Copy link
Author

No.
Because in node v0.4.x http.request exists, but you need to do http.createClientto make it work.
(tested with node v0.4.12 and v0.6.1)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants