PSMDB operator - support revisionhistorylimit #604
Conversation
DrFaust92
requested review from
eleo007,
hors,
jvpasinatto,
nmarukovich,
tplavcic and
valmiranogueira
as code owners
| {{- end }} | ||
| spec: | ||
| replicas: {{ .Values.replicaCount }} | ||
| revisionHistoryLimit: {{ .Values.revisionHistoryLimit }} |
There was a problem hiding this comment.
Have '| default 10' would be good I think (maybe someone forgets or removes the item from values by mistake?)
There was a problem hiding this comment.
if someone removes this it will take it from the chart default values.
There was a problem hiding this comment.
Not in case a --values flag is used during installation/upgrade
There was a problem hiding this comment.
Please add an if for this value or use | default, to avoid any unset or old values.yaml (same approach is also used for new values introduced in all operators)
|
jvpasinatto can this be merged? |
|
Hi @DrFaust92 could you please move the base branch to release-psmdb-1.22.0 and remove version step, this will be included in next release. Thank you! |
DrFaust92
force-pushed
the
revisionhistorylimit
branch
from
e99f520 to
80d979d
Compare
DrFaust92
requested review from
ademidoff and
maxkondr
and removed request for
a team
Signed-off-by: drfaust92 <[email protected]>
DrFaust92
force-pushed
the
revisionhistorylimit
branch
from
80d979d to
0fadcfe
Compare
|
valmiranogueira made the changes, let me know if this is what you meant |
Signed-off-by: drfaust92 <[email protected]>
4 participants
No description provided.