Use systemctl --system daemon-reload and ignore errors in postinst #1212
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guoard
requested review from
JiriCtvrtka and
idoqo
and removed request for
a team
Ensures the postinst script does not fail if daemon-reload returns a non-zero exit code. Uses the `--system` flag to explicitly target the system manager, following the common pattern in other Debian packages.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1212 +/- ##
==========================================
- Coverage 70.88% 64.89% -6.00%
==========================================
Files 28 29 +1
Lines 3569 2427 -1142
==========================================
- Hits 2530 1575 -955
+ Misses 904 712 -192
- Partials 135 140 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JiriCtvrtka
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures the postinst script does not fail if daemon-reload returns a non-zero exit code. Uses the
--systemflag to explicitly target the system manager, following the common pattern in other Debian packages.