Make mongodb_exporter user creation idempotent in postinst script #1211
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guoard
requested review from
JiriCtvrtka and
ademidoff
and removed request for
a team
The previous postinst script unconditionally ran `useradd` to create the `mongodb_exporter` system user. That would fail if the user already existed (e.g., during package upgrade), breaking the post-install process.
idoqo
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous postinst script unconditionally ran
useraddto create themongodb_exportersystem user.That would fail if the user already existed (e.g., during package upgrade), breaking the post-install process.