Skip to content

Fix: Make the case []interface{} processed consist with the case primitve.A #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LinPr wants to merge 4 commits into
base: main
Choose a base branch
from
+1 −1
Open

Fix: Make the case []interface{} processed consist with the case primitve.A #1135

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
12fb25f
fix: make the case []interface{} process consist with the case primit…
LinPr Aug 8, 2025
5df600f
Merge branch 'main' into fix
LinPr Aug 18, 2025
9ff3a96
Merge branch 'main' into fix
LinPr Aug 26, 2025
b6c2de3
Merge branch 'main' into fix
idoqo Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion exporter/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ func makeMetrics(prefix string, m bson.M, labels map[string]string, compatibleMo
case primitive.A:
res = append(res, processSlice(nextPrefix, v, l, compatibleMode)...)
case []interface{}:
continue
res = append(res, processSlice(nextPrefix, v, l, compatibleMode)...)
Copy link
Contributor

@JiriCtvrtka JiriCtvrtka Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can simplify this and merge this case with primitive.A

case primitive.A, []interface{}: res = append(res, processSlice(nextPrefix, v, l, compatibleMode)...)

Copy link
Contributor Author

@LinPr LinPr Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can simplify this and merge this case with primitive.A

case primitive.A, []interface{}: res = append(res, processSlice(nextPrefix, v, l, compatibleMode)...)

I tried, not workable, there will be an error like this.
6658baebb26076b22e218081aabbcd1f

default:
rm, err := makeRawMetric(prefix, k, v, l)
if err != nil {
Expand Down
Loading