-
-
Notifications
You must be signed in to change notification settings - Fork 30
feat(docker): Allow the docker version to run only specific interpolation #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Another thing that has been requested many times in the past, such as #290 and elsewhere. I think this PR looks ok but it adds a lot of length and duplication to the file. Can we have each step of the "full" interpolation process run in either the case where it was specified, or when no parameters were passed at all? I appreciate the intent of retaining backwards compatibility by throwing the old code in an |
Removed the if/else construct and implemented the same functionality by checking the amount of additional arguments each time. Lines 51 to 71 in 6cf2dca
|
👋 I did some awesome work for the Pelias project and would love for everyone to have a look at it and provide feedback.
Here's the reason for this change 🚀
I use the download routine from pelias to download the required osm data and extract the polylines from it. But since I don't want to import the osm data it is kinda annoying to delete them and then run the interpolation. Since the interpolation step takes quite some time it is very frustrating if you forgot this and wait that unused data is interpolated.
Here's what actually got changed 👏
Allow the
pelias prepare interpolation
additional arguments which data should only be used (osm, oa, tiger). So you can skip parts where data is present but not used. You can also mix up (e.g..pelias prepare interpolation osm tiger
).Here's how others can test the changes 👀
pelias prepare interpolation oa
=> only oa data should be interpolatedReference PR: pelias/docker#385