Fix memory leak in PFSQLiteDatabase. #629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Yep. Good catch. We really should turn on the warning for implicit capture of self... |
nlutsenko
added a commit
that referenced
this pull request
Dec 8, 2015
Fix memory leak in PFSQLiteDatabase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a leak here, we are referencing an ivar, which is implicitly referencing
selfinside aBFExecutor, which is also retained byself.Fixed simply by using a shared queue pointer, which eliminates reference to
self. Verified via Instruments.app both on iPhone 6S and Simulator.Fixes #626.