Call SingleBlockMigrations from frame_system::Config on try_on_runtime_upgrade #9451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomarQ
changed the title
bkchr
approved these changes
Aug 7, 2025
ggwpez
approved these changes
Aug 8, 2025
ggwpez
added
A4-backport-stable2506
|
I hope we can still backport stuff into unstable2507 since the runtimes will directly go to that. |
|
I think all CI checks related to this PR are now passing |
bkchr
reviewed
Sep 1, 2025
The fixed method is inside |
|
Also important to note that this is a bug. |
paritytech-release-backport-bot bot
pushed a commit
that referenced
this pull request
Sep 2, 2025
…e_upgrade (#9451) Recently, when moving the single block migrations from `frame_executive::Executive` to `SingleBlockMigrations` in `frame_system::Config`, I noticed that `try_runtime_upgrade` was ignoring the `SingleBlockMigrations` defined in frame_system. More context at polkadot-fellows/runtimes#844 Based on PR #1781 and [PRDoc](https://github.com/paritytech/polkadot-sdk/blob/beb9030b249cc078b3955232074a8495e7e0302a/prdoc/1.9.0/pr_1781.prdoc#L29), the new way for providing the single block migrations should be through `SingleBlockMigrations` in `frame_system::Config`. Providing them from `frame_executive::Executive` is still supported, but from what I understood is or will be deprecated. > `SingleBlockMigrations` this is the new way of configuring migrations that run in a single block. Previously they were defined as last generic argument of Executive. This shift is brings all central configuration about migrations closer into view of the developer (migrations that are configured in Executive will still work for now but is deprecated). ## Follow-up Changes Will try to open a pull request tomorrow for deprecating the use of `OnRuntimeUpgrade` in `frame_executive::Executive`. (cherry picked from commit 7753112)
|
Successfully created backport PR for |
|
Successfully created backport PR for |
paritytech-release-backport-bot bot
pushed a commit
that referenced
this pull request
Sep 2, 2025
…e_upgrade (#9451) Recently, when moving the single block migrations from `frame_executive::Executive` to `SingleBlockMigrations` in `frame_system::Config`, I noticed that `try_runtime_upgrade` was ignoring the `SingleBlockMigrations` defined in frame_system. More context at polkadot-fellows/runtimes#844 Based on PR #1781 and [PRDoc](https://github.com/paritytech/polkadot-sdk/blob/beb9030b249cc078b3955232074a8495e7e0302a/prdoc/1.9.0/pr_1781.prdoc#L29), the new way for providing the single block migrations should be through `SingleBlockMigrations` in `frame_system::Config`. Providing them from `frame_executive::Executive` is still supported, but from what I understood is or will be deprecated. > `SingleBlockMigrations` this is the new way of configuring migrations that run in a single block. Previously they were defined as last generic argument of Executive. This shift is brings all central configuration about migrations closer into view of the developer (migrations that are configured in Executive will still work for now but is deprecated). ## Follow-up Changes Will try to open a pull request tomorrow for deprecating the use of `OnRuntimeUpgrade` in `frame_executive::Executive`. (cherry picked from commit 7753112)
EgorPopelyaev
pushed a commit
that referenced
this pull request
Sep 2, 2025
Backport #9451 into `stable2506` from RomarQ. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Rodrigo Quelhas <[email protected]>
bkchr
pushed a commit
that referenced
this pull request
Sep 4, 2025
Backport #9451 into `unstable2507` from RomarQ. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Rodrigo Quelhas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, when moving the single block migrations from
frame_executive::ExecutivetoSingleBlockMigrationsinframe_system::Config, I noticed thattry_runtime_upgradewas ignoring theSingleBlockMigrationsdefined in frame_system. More context at polkadot-fellows/runtimes#844Based on PR #1781 and PRDoc, the new way for providing the single block migrations should be through
SingleBlockMigrationsinframe_system::Config. Providing them fromframe_executive::Executiveis still supported, but from what I understood is or will be deprecated.Follow-up Changes
Will try to open a pull request tomorrow for deprecating the use of
OnRuntimeUpgradeinframe_executive::Executive.