Add renderLit to render-component #370
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geireann
changed the title
ericelliott
reviewed
Jun 12, 2024
| const $ = renderLit(html`<div>Text</div>`); | ||
| const contains = match($('.contents').html()); | ||
|
|
||
| assert({ |
Collaborator
There was a problem hiding this comment.
This test would fail, right?
Collaborator
|
We are using |
Collaborator
|
What's the status of this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an additional
renderLitfunction into theriteway/render-componentpath of this package to support Lit elements. TherenderLitfunction takes in an element parameter of type TemplateResult and returns a Cheerio instance that can be used in the exact same way as the previousrenderfor Lit elements.The default
rendermethod will userenderReactand use the previous implementation.Todo: