Fix Pkcs11::new bug preventing PKCS#11 library loading #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll-assigned variables; this resolves an issue that prevented my PKCS#11 library from loading Signed-off-by: mematthias <[email protected]>
Jakuje
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a small excerpt from the #289 PR.
Summary
This PR fixes a critical issue in
Pkcs11::newthat prevented my PKCS#11 library from being loaded correctly. The root cause was the use ofMaybeUninit::uninit()in a context where zero-initialized ornull-assigned variables were required. This has been resolved by using explicitlynull-assigned variables instead.Changes
Pkcs11::newrelated to improper initialization, resolving library loading failure