fix: support MemoryArena allocations up to 4GB #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A MemoryArena should support allocations up to 4GB and #60 broke this by not accounting for the "max page id" when pages are now 50% the size of what the originally were. This cleans up the code so things stay in sync if we change NUM_BITS_PAGE_ADDR again and adds a unit test
eeeebbbbrrrr
commented
Sep 19, 2025
Signed-off-by: Eric Ridge <[email protected]>
rebasedming
approved these changes
Sep 19, 2025
stuhood
approved these changes
Sep 19, 2025
mdashti
pushed a commit
that referenced
this pull request
Oct 21, 2025
A MemoryArena should support allocations up to 4GB and #60 broke this by not accounting for the "max page id" when pages are now 50% the size of what the originally were. This cleans up the code so things stay in sync if we change NUM_BITS_PAGE_ADDR again and adds a unit test
mdashti
pushed a commit
that referenced
this pull request
Oct 22, 2025
A MemoryArena should support allocations up to 4GB and #60 broke this by not accounting for the "max page id" when pages are now 50% the size of what the originally were. This cleans up the code so things stay in sync if we change NUM_BITS_PAGE_ADDR again and adds a unit test
mdashti
pushed a commit
that referenced
this pull request
Oct 22, 2025
A MemoryArena should support allocations up to 4GB and #60 broke this by not accounting for the "max page id" when pages are now 50% the size of what the originally were. This cleans up the code so things stay in sync if we change NUM_BITS_PAGE_ADDR again and adds a unit test
mdashti
pushed a commit
that referenced
this pull request
Dec 3, 2025
A MemoryArena should support allocations up to 4GB and #60 broke this by not accounting for the "max page id" when pages are now 50% the size of what the originally were. This cleans up the code so things stay in sync if we change NUM_BITS_PAGE_ADDR again and adds a unit test
mdashti
pushed a commit
that referenced
this pull request
Dec 3, 2025
A MemoryArena should support allocations up to 4GB and #60 broke this by not accounting for the "max page id" when pages are now 50% the size of what the originally were. This cleans up the code so things stay in sync if we change NUM_BITS_PAGE_ADDR again and adds a unit test
stuhood
pushed a commit
that referenced
this pull request
Dec 3, 2025
A MemoryArena should support allocations up to 4GB and #60 broke this by not accounting for the "max page id" when pages are now 50% the size of what the originally were. This cleans up the code so things stay in sync if we change NUM_BITS_PAGE_ADDR again and adds a unit test
stuhood
pushed a commit
that referenced
this pull request
Dec 10, 2025
A MemoryArena should support allocations up to 4GB and #60 broke this by not accounting for the "max page id" when pages are now 50% the size of what the originally were. This cleans up the code so things stay in sync if we change NUM_BITS_PAGE_ADDR again and adds a unit test
stuhood
pushed a commit
that referenced
this pull request
Dec 10, 2025
A MemoryArena should support allocations up to 4GB and #60 broke this by not accounting for the "max page id" when pages are now 50% the size of what the originally were. This cleans up the code so things stay in sync if we change NUM_BITS_PAGE_ADDR again and adds a unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A MemoryArena should support allocations up to 4GB and #60 broke this by not accounting for the "max page id" when pages are now 50% the size of what the originally were.
This cleans up the code so things stay in sync if we change NUM_BITS_PAGE_ADDR again and adds a unit test