Skip to content

ENH: Deprecate non-keyword arguments for Index.set_names. #41551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jreback merged 11 commits into from
May 27, 2021
Merged

ENH: Deprecate non-keyword arguments for Index.set_names. #41551

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f6e9ac1
ENH: Deprecate non-keyword arguments for Index.set_names.
jmholzer May 18, 2021
17f5ff0
ENH: Deprecate non-keyword arguments for Index.set_names.
jmholzer May 19, 2021
ec20b8b
Merge branch 'master' into deprecate-nonkeyword-args-set_index
jreback May 21, 2021
a94c8ea
Merge remote-tracking branch 'upstream/master' into pr/jmholzer/41551
MarcoGorelli May 23, 2021
fc525c8
ENH: Deprecate non-keyword arguments for Index.set_names.
jmholzer May 25, 2021
34b4f2f
merge
jmholzer May 25, 2021
aa2e644
ENH: Deprecate non-keyword arguments for Index.set_names.
jmholzer May 25, 2021
d38573b
merge
jmholzer May 25, 2021
2d39763
Fix commented decorator.
jmholzer May 25, 2021
1340963
Merge remote-tracking branch 'upstream/master' into pr/jmholzer-depre…
MarcoGorelli May 26, 2021
dc528b0
fixup
MarcoGorelli May 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/source/whatsnew/v1.3.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,6 +648,7 @@ Deprecations
- Deprecated setting :attr:`Categorical._codes`, create a new :class:`Categorical` with the desired codes instead (:issue:`40606`)
- Deprecated behavior of :meth:`DatetimeIndex.union` with mixed timezones; in a future version both will be cast to UTC instead of object dtype (:issue:`39328`)
- Deprecated using ``usecols`` with out of bounds indices for ``read_csv`` with ``engine="c"`` (:issue:`25623`)
- Deprecated passing arguments as positional in :meth:`Index.set_names` (except for ``names``) (:issue:`41485`)

.. ---------------------------------------------------------------------------

Expand Down
2 changes: 2 additions & 0 deletions pandas/core/indexes/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
from pandas.util._decorators import (
Appender,
cache_readonly,
deprecate_nonkeyword_arguments,
doc,
)

Expand Down Expand Up @@ -1526,6 +1527,7 @@ def _set_names(self, values, level=None) -> None:

names = property(fset=_set_names, fget=_get_names)

@deprecate_nonkeyword_arguments(version="2.0", allowed_args=["self", "names"])
Copy link
Member

@MarcoGorelli MarcoGorelli May 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put version=None? I know I'd originally put version="2.0", but then other reviewers expressed a preference for not specifying the exact version.

Copy link
Contributor Author

@jmholzer jmholzer May 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in my latest commit.

I think these changes also apply to the PR I opened for drop_duplicates (#41500)

Would you like me to make these changes there too?

Copy link
Member

@MarcoGorelli MarcoGorelli May 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please, thanks! Your help with these is much appreciated

@final
def set_names(self, names, level=None, inplace: bool = False):
"""
Expand Down
13 changes: 13 additions & 0 deletions pandas/tests/indexes/multi/test_get_set.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,19 @@ def test_set_names_with_nlevel_1(inplace):
tm.assert_index_equal(result, expected)


def test_multi_set_names_pos_args_deprecation():
# GH#41485
idx = MultiIndex.from_product([["python", "cobra"], [2018, 2019]])

msg = (
"Starting with pandas version 2.0 all arguments of Index.set_names "
"except for the argument 'names' will be keyword-only"
)

with tm.assert_produces_warning(FutureWarning, match=msg):
idx.set_names(["kind", "year"], None)
Copy link
Member

@MarcoGorelli MarcoGorelli May 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also check the result? Again, I'm aware that I didn't do this in the example PR I opened, but then other reviewers suggested it - there's an example in #41511 . Same for the Series test

Copy link
Contributor Author

@jmholzer jmholzer May 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, added in the latest commit.



@pytest.mark.parametrize("ordered", [True, False])
def test_set_levels_categorical(ordered):
# GH13854
Expand Down
13 changes: 13 additions & 0 deletions pandas/tests/indexes/test_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1738,3 +1738,16 @@ def test_construct_from_memoryview(klass, extra_kwargs):
result = klass(memoryview(np.arange(2000, 2005)), **extra_kwargs)
expected = klass(range(2000, 2005), **extra_kwargs)
tm.assert_index_equal(result, expected)


def test_index_set_names_pos_args_deprecation():
# GH#41485
idx = Index([1, 2, 3, 4])

msg = (
"Starting with pandas version 2.0 all arguments of Index.set_names "
"except for the argument 'names' will be keyword-only"
)

with tm.assert_produces_warning(FutureWarning, match=msg):
idx.set_names("quarter", None)