Skip to content

PERF: Fix performance regression in infer_dtype #30202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Dec 23, 2019
Merged

PERF: Fix performance regression in infer_dtype #30202

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9edf9b3
Move skipna check to after type casting of values.
groutr Dec 11, 2019
70c8bed
Add entry to whatsnew.
groutr Dec 11, 2019
ea579f7
Update doc/source/whatsnew/v1.0.0.rst
groutr Dec 11, 2019
df55864
Add asv tests for skipna.
groutr Dec 11, 2019
28c4969
Merge branch 'infer_dtype_perf' of github.com:groutr/pandas into infe…
groutr Dec 11, 2019
94a968c
make pep8 happy.
groutr Dec 11, 2019
3ba2229
make black happy.
groutr Dec 12, 2019
f97fb1f
make isort happy.
groutr Dec 13, 2019
a5efb8f
Make dtype inference test cases larger.
groutr Dec 16, 2019
903abc2
Merge branch 'master' into infer_dtype_perf
groutr Dec 16, 2019
8d7ec5d
Fix benchmark params.
groutr Dec 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/source/whatsnew/v1.0.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,6 +645,7 @@ Performance improvements
- Performance improvement when checking if values in a :class:`Categorical` are equal, equal or larger or larger than a given scalar.
The improvement is not present if checking if the :class:`Categorical` is less than or less than or equal than the scalar (:issue:`29820`)
- Performance improvement in :meth:`Index.equals` and :meth:`MultiIndex.equals` (:issue:`29134`)
- Performance improvement in :func:`infer_dtype` when ``skipna`` is ``True`` (:issue:`28814`)

.. _whatsnew_1000.bug_fixes:

Expand Down
6 changes: 3 additions & 3 deletions pandas/_libs/lib.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1259,16 +1259,16 @@ def infer_dtype(value: object, skipna: bool = True) -> str:
# make contiguous
values = values.ravel()

if skipna:
values = values[~isnaobj(values)]

val = _try_infer_map(values)
if val is not None:
return val

if values.dtype != np.object_:
values = values.astype('O')

if skipna:
values = values[~isnaobj(values)]

n = len(values)
if n == 0:
return 'empty'
Expand Down