-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
PERF: Use is_utc check to improve performance of dateutil UTC in DatetimeIndex methods #23772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @mroeschke! Thanks for submitting the PR.
|
lgtm. I bet this actually fixed a bug where a dateutil UTC value was not treated correctly? |
Also datetime.timezones.utc in py3 |
Codecov Report
@@ Coverage Diff @@
## master #23772 +/- ##
==========================================
- Coverage 92.24% 92.24% -0.01%
==========================================
Files 161 161
Lines 51433 51431 -2
==========================================
- Hits 47446 47444 -2
Misses 3987 3987
Continue to review full report at Codecov.
|
thanks @mroeschke as above, if you find some issues that now are closable because of the better checking (mine and @jbrockmendel comments). pls issue a PR with tests. |
git diff upstream/master -u -- "*.py" | flake8 --diff
Benchmarks from
timeseries.py
andtimestamp.py