-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
DOC: Remove incorrect periods at the end of parameter types (#23597) #23600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Remove incorrect periods at the end of parameter types (#23597) #23600
Conversation
Hello @meiermark! Thanks for submitting the PR.
|
Codecov Report
@@ Coverage Diff @@
## master #23600 +/- ##
=======================================
Coverage 92.25% 92.25%
=======================================
Files 161 161
Lines 51262 51262
=======================================
Hits 47292 47292
Misses 3970 3970
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
cc @datapythonista : Anything needed to enforce the rule now that these violations have been fixed?
Thanks for taking care of those @meiermark @gfyoung we don't have the validation of docstring in place yet, I'm adding it in #22854, I'll add this error there, so it starts to be checked when merged |
git diff master -u -- "*.py" | flake8 --diff