fix: Page meta not change after language switch and potential memory issues on localization #12217
Conversation
memoyil
requested review from
Chef-Yogi,
chefjackson,
ChefJerry,
thechefpenguin,
chef-eric,
chef-ryan and
chefphilip
as code owners
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
7 Skipped Deployments
|
memoyil
changed the title
memoyil
changed the title
|
|
||
| export const LanguageContext = createContext<ContextApi | undefined>(undefined) | ||
|
|
||
| const cache = new Map<string, string>() | ||
| const cache = new LRU<string, string>({ maxSize: 250 }) |
There was a problem hiding this comment.
changed to lru for avoiding memory issues
| const cacheKey = `${lang}:${ver}:${key}-${JSON.stringify(data)}` | ||
| if (cache.has(cacheKey)) { | ||
|
|
||
| const cacheKey = data ? `${lang}:${ver}:${key}-${JSON.stringify(data)}` : undefined |
There was a problem hiding this comment.
no need to use cache where there is no data
| bundle: Record<string, string> | ||
| ver: number | ||
| isFetching: boolean | ||
| }>({ | ||
| }>(() => ({ | ||
| language: lang, |
There was a problem hiding this comment.
added to state to change language and bundle at the same time, to avoid render mismatchs
| @@ -0,0 +1,79 @@ | |||
| export interface LRUOptions { | |||
There was a problem hiding this comment.
copied directly from utils package to not have dep on it
memoyil
changed the title
memoyil
changed the title
Root cause is, bundle and locale not changing at the same time and if locale used as cache key (https://github.com/pancakeswap/pancake-frontend/blob/develop/apps/web/src/config/constants/meta.ts#L113) it will end up calling obsolete translation function which results old results
To reproduce
Go to swap
Change language
See title remains on the old language
PR-Codex overview
This PR introduces a new
LRU(Least Recently Used) caching mechanism to optimize language bundle management in a localization context. It enhances theuseLocaleBundlehook andLanguageProvidercomponent by implementing caching for improved performance.Detailed summary
LRUclass andLRUOptionsinterface inlru.tsfor caching.useLocaleBundleto includelanguagein state and useLRUfor caching.LanguageProviderto replaceMapwithLRUfor cache management.LanguageProvider.