Skip to content

Added support for argument file provided by Spring Boot for native bu… #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pivotal-david-osullivan merged 1 commit into from
Oct 26, 2022
Merged

Added support for argument file provided by Spring Boot for native bu… #272

pivotal-david-osullivan merged 1 commit into from
Oct 26, 2022

Conversation

@pivotal-david-osullivan
Copy link
Contributor

@pivotal-david-osullivan pivotal-david-osullivan commented Oct 25, 2022

…ilds

Summary

Addresses paketo-buildpacks/native-image#204 by setting the enviornment variable BP_NATIVE_IMAGE_BUILD_ARGUMENTS_FILE when an argfile is found at the expected location of META-INF/native-image/argfile. The native-image buildpack can read this variable and add the argfile to the native-image build command.

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@pivotal-david-osullivan pivotal-david-osullivan added semver:minor A change requiring a minor version bump type:enhancement A general enhancement labels Oct 25, 2022
@pivotal-david-osullivan pivotal-david-osullivan requested a review from a team October 25, 2022 16:48
dmikusa
dmikusa approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@dmikusa dmikusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@dmikusa dmikusa mentioned this pull request Oct 26, 2022
Closed
@pivotal-david-osullivan pivotal-david-osullivan merged commit edc9f59 into main Oct 26, 2022
@pivotal-david-osullivan pivotal-david-osullivan deleted the exclude-config-support branch October 26, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmikusa dmikusa dmikusa approved these changes

Assignees

No one assigned

Labels

semver:minor A change requiring a minor version bump type:enhancement A general enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pivotal-david-osullivan @dmikusa