Fix const-generics feature on 16-bit targets #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, compiling typenum with the const-generics feature on 16-bit
targets causes an error due to conflicting implementations of the ToUInt
trait for Const<0> as the generated code assumes that the pointer width
is at least 32. This patch adds support for 16-bit targets to the
generated code.
The problem can be reproduced with:
RUSTFLAGS="-C target-cpu=atmega328p" cargo +nightly build -Z build-std=core --target=avr-none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, compiling typenum with the const-generics feature on 16-bit targets causes an error due to conflicting implementations of the ToUInt trait for Const<0> as the generated code assumes that the pointer width is at least 32. This patch adds support for 16-bit targets to the generated code.
The problem can be reproduced with: