Add Zero trait (resolves #132) #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paholg
reviewed
Apr 1, 2020
Owner
paholg
left a comment
paholg
left a comment
There was a problem hiding this comment.
Hey, sorry I have been unresponsive. I did not have the mental energy to look at this repo for a while there.
It looks like you're missing an impl for B0, and would you mind adding an entry to the CHANGELOG? Otherwise, LGTM.
src/marker_traits.rs
Outdated
| pub trait NonZero {} | ||
|
|
||
| /// A **marker trait** to designate that a type is zero. Only `B0`, `U0`, and `Z0` | ||
| /// implements this crate. |
Owner
There was a problem hiding this comment.
Typos:
Suggested change
| /// implements this crate. | |
| /// implement this trait. |
Contributor
Author
|
The PR is now rebased to the master. |
Owner
|
Sorry for the delay; thanks! |
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a specific trait
ZeroforB0,U0andZ0. It resolves the issue #132.