yAxis no longer accept objects

[chripede]

After upgrading to 0.0.9 this no longer works:

yAxis: {
    title: {
        text: null,
    },
    labels: {
        format: "{value}%"
    },
    max: 100,
    tickInterval: 20
}

If I add it to yAxis as an array it does work, but according to Highcharts docs this should only be needed if there are multiple axes. http://api.highcharts.com/highcharts#yAxis

[cedricduffournet]

I have the same issue. It seems to work by moving yAxis configuration in chartConfig.options :

chartConfig = {
    options: {
        yAxis: {
            title: {
                text: null,
            },
            labels: {
                format: "{value}%"
            },
            max: 100,
            tickInterval: 20
        }
    }
}

[pablojim]

ok I'll have a look at this. Suggest sticking with 0.0.8 for now.

[bakurin]

It seems there is an error in function

deepExtend(destination, source)

error occurs line 115 when source var is an object and destination is undefined:

destination[property] = deepExtend(destination[property] || {}, source[property]);

[TheSharpieOne]

I didn't see this ticket when I created a PR... so I'll put this information here which better documents the issue:

TypeError: Cannot read property '<PROPERTY>' of undefined
where the destination is undefined.

this recent change from 0.8 to 0.9 which uses deepExtend instead of angular.copy is what is triggering the issue in the recent change (since deepExtend did not change).

Breaking it down:
This recent change adds a default for xAxis, but no default for yAxis was added. Not supplying one in the config.options will cause mergedOptions[axisName] to be undefined when axisName is 'yAxis' (which it gets from this array). When it tries to deepExtend the config.yAxis on to that, this issue occurs.

[brandonrobertz]

This broke us automatically (semVer). Why are we rolling our own deepExtend here? That functionality exists in so many more stable libraries (angular.merge, for example or lodash).

[pablojim]

Close see #369