Skip to content

Conversation

@hnzlmnn
Copy link

@hnzlmnn hnzlmnn commented Nov 28, 2019

Added the ability to unpack webpack bundles into source directory. Could be implementing #11. For now, I created an argument switch to enable the feature as I only tested with a handful of webpack bundles.

@lgtm-com
Copy link

lgtm-com bot commented Nov 28, 2019

This pull request introduces 1 alert when merging 84fdd74 into f0dbf72 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@paazmaya
Copy link
Owner

paazmaya commented Dec 2, 2019

Hi, Thank you for the contribution.

How about test cases, can you add those with fixtures?

Also, please "sign-off" the commits, in order to mark the contibution as a contribution. The DCO checks for that.

@hnzlmnn hnzlmnn mentioned this pull request Dec 2, 2019
@codecov
Copy link

codecov bot commented Dec 2, 2019

Codecov Report

❌ Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.37%. Comparing base (f0dbf72) to head (8c520ab).
⚠️ Report is 199 commits behind head on master.

Files with missing lines Patch % Lines
lib/read-sources.js 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
- Coverage   90.19%   89.37%   -0.83%     
==========================================
  Files           6        6              
  Lines         153      160       +7     
==========================================
+ Hits          138      143       +5     
- Misses         15       17       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Malte Heinzelmann <[email protected]>
Signed-off-by: Malte Heinzelmann <[email protected]>
@paazmaya
Copy link
Owner

@hnzlmnn hi, sorry for not coming back to this faster, but the test cases are still missing in this PR, please add example files as fixtures and resulting files as expected, than assert between them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants