Add jump hosts #103
Merged
Add jump hosts #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
Tests/CitadelTests/EndToEndTests.swift:172
- [nitpick] The test could be improved by adding additional assertions to verify that the jump connection behaves as expected beyond just checking that the command output is non-empty.
let client2 = try await client.jump(to: settings)
| } | ||
|
|
||
| public func jump(to settings: SSHClientSettings) async throws -> SSHClient { | ||
| let originatorAddress = try SocketAddress(ipAddress: "fe80::1", port: 22) |
There was a problem hiding this comment.
The originatorAddress is hardcoded to a specific link-local IP address which might not be valid in all environments. Consider making this value configurable or derived based on the client's network context.
Closed
Joannis
force-pushed
the
jo/add-jump-host-helpers
branch
from
eae9e1d to
a3025ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #99