Skip to content

Conversation

@Joannis
Copy link
Member

@Joannis Joannis commented Apr 5, 2025

No description provided.

@Joannis Joannis requested a review from Copilot April 5, 2025 12:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

Sources/Citadel/SSHConnectionPoolSettings.swift:1

  • The renaming of SSHConnectionSettings to SSHConnectionPoolSettings may introduce naming ambiguity when viewed alongside the newly introduced SSHConnectionSettings in ClientSession.swift. Consider clarifying the distinction between pool settings and individual session settings, either via naming or documentation.
internal struct SSHConnectionPoolSettings {

Sources/Citadel/ClientSession.swift:37

  • This new SSHConnectionSettings struct may be confused with the renamed SSHConnectionPoolSettings from another file. It would be helpful to ensure that the naming clearly reflects that these settings are for individual SSH sessions.
public struct SSHConnectionSettings: Sendable {

@Joannis Joannis force-pushed the jo/add-connection-settings branch from 2deb231 to 8c0d093 Compare April 5, 2025 12:55
@Joannis Joannis merged commit 119c62a into jo/sendable-conformances Apr 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants