MicroPython
Are ASM_MOV_REG_IMM_FIX_U16 and ASM_MOV_REG_IMM_FIX_WORD still needed?
#12771
-
|
I'm having some fun trying to add the RISCV native code emitter to MicroPython (only RV32I/RV32M for now) and I noticed that all other native code emitters have a concrete definition for Is there any known code outside MicroPython's source tree that uses them? If they can be safely removed I can send a PR that cleans that bit up (and I won't implement those in my emitter, of course :)). |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 3 replies
-
|
@agatti Excited to hear about a RISCV emitter! Those two macros were used until the .mpy improvements last year (I can't seem to find the exact PR but it was related to, but slightly after #8191). The relevant commits are 1fb01bd and d4d53e9 So I think it should be safe to remove them. |
Beta Was this translation helpful? Give feedback.
-
|
@jimmo Fair enough, I'll send a PR for that then! Regarding RISCV, the emitter may need a fair bit of internal changes - do I find the maintainers' team on discord or is there any other way to get in touch rather than on here? Not for secrecy but for a possibly quicker response time, that is :) |
Beta Was this translation helpful? Give feedback.
-
|
Yep we're on the Discord. The |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
@agatti Excited to hear about a RISCV emitter!
Those two macros were used until the .mpy improvements last year (I can't seem to find the exact PR but it was related to, but slightly after #8191). The relevant commits are 1fb01bd and d4d53e9
So I think it should be safe to remove them.