Improved pull request "Files Changed" experience feedback #163932
Replies: 1611 comments 551 replies
-
I would like to be able to scroll through the Pull Request while the comment modal is open. Reason: When a comment is outdated, we need to look at the current version to check if it actually addresses the comment. I really love this feature! THANK YOU!!! |
Beta Was this translation helpful? Give feedback.
-
Update: I just found out that it appears when there's enough space (1280px width). Here's the updated feedback. I'd like to see the branch name in the sticky header at all times so that I can easily copy it when I'm reviewing a PR. I wrote the following before thoroughly experimenting. I'd like to see the branch name when the sticky header is shown (i.e., when you've scrolled to the bottom). The reason is that when I'm reviewing a long PR and want to checkout the branch to continue reviewing it locally, I have to go back all the way up to see or copy the branch name and then go back to where I left off. |
Beta Was this translation helpful? Give feedback.
-
I find the comment indicators in the sidebar really useful. It might also be useful to have them in the "diff file header." It's very useful when you've marked a file as "viewed" because you can see how many comments it has as you're scrolling without having to expand it. |
Beta Was this translation helpful? Give feedback.
-
This is really cool. Is it also possible to seamlessly toggle hiding white spaces? If that's achievable without doing a refresh would be amazing. |
Beta Was this translation helpful? Give feedback.
-
Clicking a line number always assumes you want to add a comment. In the previous experience it only changes the URL to have deep linking. |
Beta Was this translation helpful? Give feedback.
-
This is so much better, I might go back from reviewing with the VSCode extension now 🚀 I love the new alerts panel, unfortunately it looks like pressing Maybe we could have some grouping or clustering in the alerts panel in the future. |
Beta Was this translation helpful? Give feedback.
-
I would love to see the file tree sorted alphabetically with folders on top, then files. It is quite jarring to have changed files in the middle of folders when viewing the file tree currently. Example of current state
Example of desired state
This would mirror how the majority of developers view the code in their IDE |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
Hi, I would like to play around with this, but I'm not seeing the opt-in mentioned in
Am I missing something? |
Beta Was this translation helpful? Give feedback.
-
The tab for |
Beta Was this translation helpful? Give feedback.
-
Not sure if this is the sort of feedback you're after, but the |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
On the Files changed tab I can only see 19 files out of 66. Why? |
Beta Was this translation helpful? Give feedback.
-
I used to be able to click on a useful link to see the submodule diff in PRs but now its just plain text. Could we have that back pls? |
Beta Was this translation helpful? Give feedback.
-
It doesn't always seem to remember if hide whitespace was turned on. |
Beta Was this translation helpful? Give feedback.
-
the new experience doesn't tell whether the CODEOWNERS file is valid or not, unlike the existing/current experience |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
The file-per-file review is really helpful ! The only downside is that there's now way to see what files are marked as reviewed and what files aren't at a glance |
Beta Was this translation helpful? Give feedback.
-
Cannot post a comment while selecting a line range in a file containing more deletions that additions
|
Beta Was this translation helpful? Give feedback.
-
Settings button was on left side earlier. Options like Hide whitespace were easily accessible. |
Beta Was this translation helpful? Give feedback.
-
In Firefox, while editing the text of a comment ("Write" as opposed to "Preview"), command-C doesn't work. It's OK in Chrome. |
Beta Was this translation helpful? Give feedback.
-
love
|
Beta Was this translation helpful? Give feedback.
-
There is a lot I like but having comments disappear when you go over the 40 limit makes this a non-starter for me, especially when working with PRs from a junior developer. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
Utterly baffling decision to say Who in the world can possibly review a change with a large number of files one file at a time? This is a total dealbreaker. |
Beta Was this translation helpful? Give feedback.
-
When a file has been deleted it is not possible to add a comment on the whole file (using the option next to the "viewed" checkbox). This was possible in the previous version: ![]() |
Beta Was this translation helpful? Give feedback.
-
The "Comments" dropdown at the top right is not as intuitive as the old view's "Conversations" dropdown that showed you the conversations with resolved pre-filtered out. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
Another note on the single-file PR diff view: when I select a file in the sidebar, the file is loaded but the page / view is scrolled down instead of re-scrolling back to the top of the page. It seems like it might be trying to match the point I was scrolled to on the previous file? Tough to say for sure given the differing length of diffs, but either way I'd expect the new file to load with the page scrolled to the top. |
Beta Was this translation helpful? Give feedback.
-
There needs to be a way to search all the files for text (among the diff) in a large commit. The old tool lets you do this with the browser, the new one does not. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Important
You can opt in to the public preview from any pull request via
✨Try the new experience
in the upper-right corner. You can return to the classic view by clicking the “switch back” link.About the new experience
This refresh focuses on performance, accessibility, and clarity so reviews stay responsive—even on the largest pull requests.
What’s new ?
Performance 🚀
UX ✨
Accessibility
What's missing? 🟨
As of the initial public preview release, there are some temporary limitations that will be addressed over time:
While our previous experience had hard limits on large PRs, this new experience is being built to scale. That said, we’re increasing our limits incrementally. To start with, our additional current limitations are:
How you can help
Thanks for helping us build a better review experience—we read every comment!
Beta Was this translation helpful? Give feedback.
All reactions