Skip to content

chore(patch): use stored thresholds when comparing baselines [sc-26254] #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dimlio wants to merge 1 commit into from
+3 −3
Closed

chore(patch): use stored thresholds when comparing baselines [sc-26254] #336

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Plugins/BenchmarkTool/BenchmarkTool+Baselines.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,14 +256,14 @@ extension BenchmarkTool {
/*
We store the baselines in a .benchmarkBaselines directory, by default in the package root path
unless otherwise specified.

The 'default' folder is used when no specific named baseline have been specified with the
command line. Specified 'named' baselines is useful for convenient A/B/C testing and comparisons.
Unless a host identifier have been specified on the command line (or in an environment variable),
we by default store results in 'results.json', otherwise we will use the environment variable
or command line to optionally specify a 'hostIdentifier' that allow for separation between
different hosts if checking in baselines in repos.

.benchmarkBaselines
├── target1
│ ├── default
Expand Down Expand Up @@ -445,7 +445,7 @@ extension BenchmarkBaseline: Equatable {
if let rhsResults = rhs.results.first(where: { $0.key == lhsBenchmarkIdentifier }) {
if let rhsBenchmarkResult = rhsResults.value.first(where: { $0.metric == lhsBenchmarkResult.metric }
) {
let thresholds = thresholdsForBenchmarks(
let thresholds = lhsBenchmarkResult.thresholds ?? thresholdsForBenchmarks(
benchmarks,
name: lhsBenchmarkIdentifier.name,
target: lhsBenchmarkIdentifier.target,
Expand Down
Loading