adding newline characters to special characters that require quoting … #829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertpatrick
requested review from
rakillen,
jshum2479,
CarolynRountree and
ddsharpe
jshum2479
approved these changes
Feb 2, 2021
CarolynRountree
approved these changes
Feb 2, 2021
rakillen
reviewed
Feb 2, 2021
| @@ -102,7 +102,7 @@ class PythonToYaml(object): | |||
| _class_name = 'PythonToYaml' | |||
| # 4 spaces | |||
| _indent_unit = ' ' | |||
| _requires_quotes_chars_regex = '[:{}\[\],&*#?|<>=!%@`-]' | |||
| _requires_quotes_chars_regex = '[\r\n:{}\[\],&*#?|<>=!%@`-]' | |||
There was a problem hiding this comment.
Both files need updates to copyright dates and current format:
Copyright (c) [year,] year, Oracle and/or its affiliates.
There was a problem hiding this comment.
Copyright (c) 2019, 2021, Oracle and/or its affiliates.
Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl.
rakillen
approved these changes
Feb 2, 2021
ddsharpe
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…in YAML
Fixes #823