-
Notifications
You must be signed in to change notification settings - Fork 102
Add support for GraphQL Java 19.2 #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@dnestoro I think this PR is ready to be considered for the next release. |
Sure It will be reviewed and merged in next few days together with other PRs for next release |
0e02fba
to
3f62d86
Compare
@@ -0,0 +1,3 @@ | |||
type Query { | |||
greeting: String | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add new line
|
||
input NewCharacter { | ||
name: String | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
I added new lines directly from git |
@bclozel please resolve conflicts |
This commit adds reachability metadata for the GraphQL Java project. Tests involve a simple query to trigger the base infrastructure. Since GraphQL Java will perform reflection mostly on user provided types, tests also use a complete introspection query on a complex schema to trigger reflection on GraphQL Java types.
476b09c
to
d885d19
Compare
@dnestoro I've just force-pushed my branch with the fixes and it's ready for merging. |
This PR adds reachability metadata for the GraphQL Java project.
Tests involve a simple query to trigger the base infrastructure.
Since GraphQL Java will perform reflection mostly on user provided types, tests also use a complete introspection query on a complex schema to trigger reflection on GraphQL Java types.
Other Frameworks like Micronaut ship more metadata, but I didn't manage to trigger more reflection so far.
Pinging @melix as it's related to micronaut-projects/micronaut-core#7805