Skip to content

[FSSDK-8959] [React] Update Non-Code-Path SDK Resources #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 13, 2023

Conversation

rafinutshaw-optimizely
Copy link
Contributor

@rafinutshaw-optimizely rafinutshaw-optimizely commented Mar 10, 2023

Summary

  • rename client side "full stack" text occurrences according to the ticket instructions
  • organize the readme.md file

Test plan

  • No changes here

Issues

@mikechu-optimizely mikechu-optimizely added the documentation Improvements or additions to documentation label Mar 10, 2023
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 1 change I think

package.json Outdated
@@ -1,7 +1,7 @@
{
"name": "@optimizely/react-sdk",
"version": "2.9.1",
"description": "React SDK for Optimizely Full Stack and Optimizely Rollouts",
"description": "React SDK for Optimizely Optimizely Feature Experimentation and Optimizely Rollouts",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might be:
React SDK for Optimizely Feature Experimentation, Optimizely Full Stack (legacy), and Optimizely Rollouts

Would that be okay?

cc @russell-loube-optimizely @griffincox-optimizely

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. See my suggestion below.

Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@russell-loube-optimizely russell-loube-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one link to update, otherwise looks good!

Copy link

@russell-loube-optimizely russell-loube-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please have fellow dev approve.

@rafinutshaw-optimizely rafinutshaw-optimizely merged commit d948e61 into master Mar 13, 2023
@rafinutshaw-optimizely rafinutshaw-optimizely deleted the utshaw/fx-rename branch March 13, 2023 12:36
rafinutshaw-optimizely added a commit that referenced this pull request Mar 15, 2023
* Rename fullstack to feature experimentation

* Update readme and package.json

* Fix pr

* Cleanup

* Update link in readme
# Conflicts:
#	package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants