-
Notifications
You must be signed in to change notification settings - Fork 37
[FSSDK-8959] [React] Update Non-Code-Path SDK Resources #190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just 1 change I think
package.json
Outdated
@@ -1,7 +1,7 @@ | |||
{ | |||
"name": "@optimizely/react-sdk", | |||
"version": "2.9.1", | |||
"description": "React SDK for Optimizely Full Stack and Optimizely Rollouts", | |||
"description": "React SDK for Optimizely Optimizely Feature Experimentation and Optimizely Rollouts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might be:
React SDK for Optimizely Feature Experimentation, Optimizely Full Stack (legacy), and Optimizely Rollouts
Would that be okay?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. See my suggestion below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one link to update, otherwise looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Please have fellow dev approve.
* Rename fullstack to feature experimentation * Update readme and package.json * Fix pr * Cleanup * Update link in readme # Conflicts: # package.json
Summary
Test plan
Issues