Skip to content

Fix: Upgrade to react 18 #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 31, 2022
Merged

Fix: Upgrade to react 18 #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
b24a7cf
build successful on react 18
f3sherry Apr 25, 2022
c90471b
experiment.spec updated to RTL
f3sherry May 6, 2022
50de012
experiment file's extra code removed
f3sherry May 10, 2022
6fbd47d
experiment file's extra code removed
f3sherry May 10, 2022
e521076
features.spec updated
f3sherry May 11, 2022
a67840a
hooks file added
f3sherry May 13, 2022
1db77f1
withOptimizely spec updated
f3sherry May 16, 2022
8501e85
removed enzyme from package.json
f3sherry May 17, 2022
34c110a
Merge branch 'master' into sherry/react-version-update
zashraf1985 May 17, 2022
f5cd830
updated node version to be used by tests
zashraf1985 May 17, 2022
41ef17c
trying to fix ci
zashraf1985 May 17, 2022
f2ba7d9
Merge branch 'master' into sherry/react-version-update
zashraf1985 May 17, 2022
311190f
Merge branch 'master' into sherry/react-version-update
zashraf1985 May 17, 2022
88a5134
PR suggested changes
f3sherry May 18, 2022
581a1c2
Updated CHANGELOG
zashraf1985 May 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/react.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Set up Node 10
- name: Set up Node 16
uses: actions/setup-node@v3
with:
node-version: 10
node-version: 16
- run: yarn install
- run: yarn test

Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
### Bug fixes
- addresses issues [#152](https://github.com/optimizely/react-sdk/issues/152) and [#134](https://github.com/optimizely/react-sdk/issues/134): Gracefully returns pessimistic default values when hooks fail instead of throwing an error.
- fixed issue [#156](https://github.com/optimizely/react-sdk/issues/156) - Added children prop to make the SDK compatible with React 18([#158](https://github.com/optimizely/react-sdk/pull/158)).
- Updates React SDK to use React 18 and fixed related typescript issues ([#159](https://github.com/optimizely/react-sdk/pull/159)).
- Replaces `enzyme` with `react testing library` to make unit tests work with React 18 ([#159](https://github.com/optimizely/react-sdk/pull/159)).

## [2.8.1] - March 7, 2022

Expand Down
14 changes: 6 additions & 8 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,26 +42,24 @@
"@rollup/plugin-commonjs": "^16.0.0",
"@rollup/plugin-node-resolve": "^10.0.0",
"@rollup/plugin-replace": "^2.3.4",
"@types/enzyme": "^3.1.15",
"@types/enzyme-adapter-react-16": "^1.0.3",
"@testing-library/jest-dom": "^5.16.4",
"@testing-library/react": "^13.1.1",
"@types/hoist-non-react-statics": "^3.3.1",
"@types/jest": "^26.0.14",
"@types/prop-types": "^15.5.6",
"@types/react": "^16.7.18",
"@types/react-dom": "^16.9.5",
"@types/react": "^18.0.6",
"@types/react-dom": "^18.0.2",
"@typescript-eslint/eslint-plugin": "^2.23.0",
"@typescript-eslint/parser": "^2.23.0",
"enzyme": "^3.8.0",
"enzyme-adapter-react-16": "^1.7.1",
"eslint": "^6.8.0",
"eslint-config-prettier": "^6.10.0",
"eslint-plugin-prettier": "^3.1.2",
"eslint-plugin-react": "^7.19.0",
"eslint-plugin-react-hooks": "^4.1.0",
"jest": "^26.5.2",
"prettier": "1.19.1",
"react": "^16.8.0",
"react-dom": "^16.8.0",
"react": "^18.0.0",
"react-dom": "^18.0.0",
"rollup": "^2.32.1",
"rollup-plugin-typescript2": "^0.28.0",
"rollup-plugin-uglify": "^6.0.4",
Expand Down
Loading