fix: Update VariableValuesObject type to handle JSON type variable #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zashraf1985
suggested changes
Jul 27, 2021
README.md
Outdated
| @@ -318,7 +318,7 @@ The following type definitions are used in the `ReactSDKClient` interface: | |||
|
|
|||
| - `UserAttributes : { [name: string]: any }` | |||
| - `User : { id: string | null, attributes: userAttributes }` | |||
| - `VariableValuesObject : { [key: string]: boolean | number | string | null }` | |||
| - `VariableValuesObject : { [key: string]: unknown }` | |||
There was a problem hiding this comment.
Not sure if we should keep it unknown. will the user need to cast it or provide a type now? Will it break for the users who are already using it directly as any?
zashraf1985
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update VariableValuesObject interface to handle JSON type variable.
Issue: #117