Skip to content

Conversation

@sshine
Copy link
Contributor

@sshine sshine commented Jul 24, 2025

Improves readability when migrating to v1.39.0

Description of the change:

In the v1.39.0 migration guide, the section

 github.com/onsi/ginkgo/v2 v2.17.1
 github.com/onsi/gomega v1.32.0
 k8s.io/api v0.30.1
 k8s.io/apimachinery v0.30.1
 k8s.io/client-go v0.30.1
 sigs.k8s.io/controller-runtime v0.18.4
 github.com/onsi/ginkgo/v2 v2.19.0
 github.com/onsi/gomega v1.33.1
 k8s.io/api v0.31.0
 k8s.io/apimachinery v0.31.0
 k8s.io/client-go v0.31.0
 sigs.k8s.io/controller-runtime v0.19.0

now looks like:

- github.com/onsi/ginkgo/v2 v2.17.1
- github.com/onsi/gomega v1.32.0
- k8s.io/api v0.30.1
- k8s.io/apimachinery v0.30.1
- k8s.io/client-go v0.30.1
- sigs.k8s.io/controller-runtime v0.18.4
+ github.com/onsi/ginkgo/v2 v2.19.0
+ github.com/onsi/gomega v1.33.1
+ k8s.io/api v0.31.0
+ k8s.io/apimachinery v0.31.0
+ k8s.io/client-go v0.31.0
+ sigs.k8s.io/controller-runtime v0.19.0

as intended.

Motivation for the change:

To make the migration steps easier to read.

Checklist

If the pull request includes user-facing changes, extra documentation is required:

I haven't added a changelog entry. Let me know if I should.

@openshift-ci openshift-ci bot requested review from OchiengEd and jberkhahn July 24, 2025 14:09
@acornett21
Copy link
Contributor

Hi @sshine thanks for the contribution. A changelog entry isn't needed for this, but you will need to sign-off your commit to get the DCO check to pass. More on that below
https://github.com/operator-framework/operator-sdk/pull/6975/checks?check_run_id=46652890495

Improves readability when migrating to v1.39.0

Signed-off-by: Simon Shine <[email protected]>
@sshine
Copy link
Contributor Author

sshine commented Jul 24, 2025

Done. Ironically, since I switched from a web commit to an --amended commit om my computer, it lacks my cryptographic signature now. ;-)

@acornett21 acornett21 merged commit ed4df85 into operator-framework:master Jul 24, 2025
20 of 21 checks passed
@sshine sshine deleted the patch-1 branch July 24, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants