FreeBSD: unbreak compilation on i386 #18096
Open
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/zfs-tests/cmd/mmap_seek.c: use correct printf specifier module/zfs/vdev.c: vdev_clear(): correctly cast argument to atomic_add_64() Signed-off-by: Martin Matuska <[email protected]>
amotin
reviewed
Dec 31, 2025
Comment on lines
+58
to
60
| fprintf(stderr, "lseek(fd, %jd, SEEK_%s) = %jd (expected %jd)", | ||
| offset, (whence == SEEK_DATA ? "DATA" : "HOLE"), | ||
| seek_offset, expect_offset); |
Member
There was a problem hiding this comment.
Formally I think %jd is uintmax_t, which might be bigger than off_t.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The compilation on FreeBSD i386 is broken.
Description
Incorrect printf specifier in mmap_seek.c
Missing cast to atomic_add_64
How Has This Been Tested?
Compilation on FreeBSD i386 and amd64
Types of changes
Checklist:
Signed-off-by.