-
Notifications
You must be signed in to change notification settings - Fork 216
Add man pages #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add man pages #20
Conversation
Signed-off-by: George Melikov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't looked at the output, but the idea is great. I made a few comments on minor things.
I see you linked to the output. Yeah, at first glance, the output looks great too! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pages look great!
|
||
# Gen man pages | ||
ZFS_GIT_REPO = https://github.com/openzfs/zfs.git | ||
ZFS_GIT_DIR = ./_build/zfs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always generating the man page from master is the right first step. But I think we should consider early on how we're going to handle generating documentation for multiple versions of OpenZFS. Adding a "Docs by version" section to the sidebar as was done for the Python documentation would be a nice way to handle this. Let's make sure to leave ourselves some options since I'm not sure how difficult it would be to add this kind of thing latter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, I thought about it too. Looks like it would be pretty easy, because now we generate docs. We may use one of sphinx modules for that, for ex. https://github.com/sphinx-contrib/sphinxcontrib-versioning to get versioned docs + man pages via script addtions.
Worst thing that may get us is different links and the need to manage redirects. In this case I prefer some 404 links from other sites but we get faster publication -> better docs now.
This looks great! Could we consider highlighting the "main" manpages, e.g. zfsconcepts, zfs, zpool? They kind of get lost among the subcommands and things that are not as relevant to sysadmins (e.g. fsck.zfs, zdb). |
I noticed that when another manpage is mentioned, it is a HTML link, but clicking on it doesn't seem to do anything. Is that just an issue with the preview, or do we need to fix something so that it will work? (This is on Safari 13.1.1 on OSX.) |
It was chrome-specific, fixed, thank you for catching that! |
mandoc
itselfPreview: https://gmelikov.github.io/openzfs-docs/man/